Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture screen to debug #235

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Capture screen to debug #235

merged 1 commit into from
Mar 25, 2024

Conversation

wesleybl
Copy link
Member

Capture the screen before the form is submitted, to debugging. Even after further attempts to fix the Add a Comment to a Document and bulk delete it test, it is still failing. See:

https://jenkins.plone.org/job/pull-request-6.0-3.11/1128/robot/report/robot_log.html#s1-s34-t1

So I took a screenshot before the form was sent, to see what's happening. The idea is to monitor Jenkins until an error occurs. Then we must remove the capture.

@mister-roboto
Copy link

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@wesleybl
Copy link
Member Author

@jenkins-plone-org please run jobs

Capture the screen before the form is submitted, to debugging.
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleybl If I understand right, this is just for debugging when you run the tests for the PR, and doesn't need to be merged. Right?

@wesleybl
Copy link
Member Author

@davisagli I actually wanted to merge this PR. I need to see the capture when the error occurs, and this error is intermittent. I will monitor Jenkins errors.

@davisagli davisagli merged commit 1bf936b into master Mar 25, 2024
13 checks passed
@davisagli davisagli deleted the fix_robot branch March 25, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants