Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resources #287

Merged
merged 3 commits into from
Sep 14, 2018
Merged

Update resources #287

merged 3 commits into from
Sep 14, 2018

Conversation

agitator
Copy link
Member

@agitator agitator commented Jun 13, 2018

@agitator agitator requested a review from thet June 13, 2018 09:59
@agitator agitator changed the title Update resources WIP Update resources Jun 14, 2018
Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunew
Copy link
Contributor

sunew commented Sep 13, 2018

Currently we have one strange failing test when the three PR's are run together, both in jenkins and locally on coredev with alltests and the three branches checked out.

I cannot explain this one.. Looking into isolating the testfailure to one or more modules.

Failed doctest test for layers.rst
  File "/home/jenkins/.buildout/eggs/plone.app.testing-5.0.8-py2.7.egg/plone/app/testing/layers.rst", line 0
----------------------------------------------------------------------
File "/home/jenkins/.buildout/eggs/plone.app.testing-5.0.8-py2.7.egg/plone/app/testing/layers.rst", line 183, in layers.rst
Failed example:
    getSiteManager()
Expected:
    <BaseGlobalComponents test-stack-2>
Got:
    <BaseGlobalComponents test-stack-3>
----------------------------------------------------------------------
File "/home/jenkins/.buildout/eggs/plone.app.testing-5.0.8-py2.7.egg/plone/app/testing/layers.rst", line 263, in layers.rst
Failed example:
    getSiteManager()
Expected:
    <BaseGlobalComponents test-stack-2>
Got:
    <BaseGlobalComponents test-stack-3>

@sunew
Copy link
Contributor

sunew commented Sep 13, 2018

see plone/plone.app.upgrade#166 for an explanation of the failing test.

@sunew
Copy link
Contributor

sunew commented Sep 14, 2018

Jenkins test: This version of pa.event requires plone.app.z3cform>=2.0.1.dev0 so not applicable for plone 5.0.

@sunew sunew merged commit cb86098 into master Sep 14, 2018
sunew added a commit that referenced this pull request Sep 14, 2018
@sunew sunew deleted the update-resources branch September 14, 2018 08:08
@agitator
Copy link
Member Author

@sunew thanx!

@sunew
Copy link
Contributor

sunew commented Sep 14, 2018

@agitator no problem, thanks for the update:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants