Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression-test for allowed_attributes #306

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented May 18, 2019

allowed_attributes and allowed_interfaces was broken in Zope 4.0
See zopefoundation/Zope#397

@mister-roboto
Copy link

@pbauer thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@pbauer
Copy link
Member Author

pbauer commented Jun 20, 2019

@jenkins-plone-org please run jobs

@pbauer pbauer merged commit 727fb23 into master Jun 21, 2019
@pbauer pbauer deleted the add_regression_test_for_allowed_attributes branch June 21, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants