-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plone6 styles #114
Plone6 styles #114
Conversation
@spereverde thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
AT first sight it didn't seem that any of the permission changes were necessary for the style update, so I left all permission related commits form the plone6 branch out for now |
@spereverde you probably wanted to request a review from @pbauer rather from me :) |
@gforcada github suggested you, I guess because you made the last commits, I will add Philip as a reviewer, thx |
@spereverde I tested this. It's an improvement but the status message looks too wide: Probably it needs to go inside a |
@davisagli I admit I didn't recheck visually on a clean setup, I'll amend a fix and let you know |
Hey Kim ! are you still planning to work on this one ? |
apparently I forgot :-) |
770d088
to
91872d4
Compare
91872d4
to
b49b097
Compare
I rebased the changes and wrapped the messages in a container |
@jenkins-plone-org please run jobs |
Adding only the style changes from #96
Since @davisagli asked to seperate out the permission changes
We'd love to have this update in in a next release since without it the statusmessages look pretty bad, or at least unstyled :-)