Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle relation-fields for working copies of folderish content #119

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Handle relation-fields for working copies of folderish content #119

merged 4 commits into from
Feb 19, 2024

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Feb 6, 2024

Fixes #118

@mister-roboto
Copy link

@pbauer thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@pbauer pbauer requested a review from sneridagh February 6, 2024 11:09
@sneridagh sneridagh requested a review from davisagli February 6, 2024 11:32
sneridagh
sneridagh approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm a bit rusty on backend matters, asking @davisagli and @ericof too!

@sneridagh sneridagh requested a review from ericof February 6, 2024 11:33
@pbauer
Copy link
Member Author

pbauer commented Feb 6, 2024

@jenkins-plone-org please run jobs

davisagli
davisagli reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the intersection of 2 dark corners of Plone (working copies and relations). I don't think I should approve this without a test.

plone/app/iterate/base.py Show resolved Hide resolved
@pbauer
Copy link
Member Author

pbauer commented Feb 12, 2024

@davisagli I added a test

@pbauer
Copy link
Member Author

pbauer commented Feb 12, 2024

@jenkins-plone-org please run jobs

@pbauer pbauer requested a review from davisagli February 12, 2024 21:10
@jensens jensens merged commit 975b5d4 into master Feb 19, 2024
12 checks passed
@jensens jensens deleted the handle_relations branch February 19, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneridagh sneridagh sneridagh approved these changes

@jensens jensens jensens approved these changes

@ericof ericof Awaiting requested review from ericof

@davisagli davisagli Awaiting requested review from davisagli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relations not handled for folderish content
5 participants
@pbauer @mister-roboto @davisagli @jensens @sneridagh