Cleanup + Added profile id "default" and deprecated id "plone.app.iterate".

[iham]

plone.app.iterate is a confusing naming for a default GenericSetup profile id as the convention is to name it "default". Having to type profile-plone.app.iterate:plone.app.iterate makes it even worse when using it.

I - by the big help of @jensens and @thet - deprecated this profile by using the new post_handler in GS 1.8.2 and added the normal default profile and updated the tests.

The only known place where profile-plone.app.iterate:plone.app.iterate is called:
https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/MigrationTool.py#L99

[mauritsvanrees]

You point at the MigrationTool that mentions the old profile id. It is a list of profiles that are checked during Plone migration, to see if any upgrade steps need to be run. If a profile id in this list no longer exists, nothing goes wrong. I think it is best to keep the line there, but you should add a line with the new id. Fine to do that after this is merged.

But I think an upgrade step should be added. And it should be for the old profile id. It should switch from the old to the new id, something like this:

version = portal_setup.getLastVersionForProfile(old profile id)
portal_setup.unsetLastVersionForProfile(old profile id)
portal_setup.setLastVersionForProfile(new profile id, version)

The result should be that portal_setup knows that the new default profile has been installed at a certain version. The result might also be that the installed version of the old profile is refreshed instead of unset, which is less nice.

Actually, it might be easier to do this in plone.app.upgrade.

Also, if you are up for it: an uninstall profile would be nice. But that is completely outside the scope of this pull request. :-)