Skip to content

Commit

Permalink
Fixed html validation: element nav does not need a role attribute.
Browse files Browse the repository at this point in the history
  • Loading branch information
mauritsvanrees committed Mar 1, 2016
1 parent 205b7d5 commit 351e0b7
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ New:

Fixes:

- Fixed html validation: element nav does not need a role attribute.
[maurits]

- Fix test isolation problems: if a test calls transaction.commit() directly or
indirectly it can not be an integration test, either avoid the commit or
change the layer into a functional one.
Expand Down
2 changes: 1 addition & 1 deletion plone/app/layout/viewlets/path_bar.pt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<nav id="portal-breadcrumbs" class="plone-breadcrumb" role="navigation"
<nav id="portal-breadcrumbs" class="plone-breadcrumb"
i18n:domain="plone"
tal:define="breadcrumbs view/breadcrumbs">
<div class="container">
Expand Down
2 changes: 1 addition & 1 deletion plone/app/layout/viewlets/sections.pt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
i18n:domain="plone">

<p class="hiddenStructure" i18n:translate="heading_sections">Navigation</p>
<nav class="plone-navbar" id="portal-globalnav-wrapper" role="navigation">
<nav class="plone-navbar" id="portal-globalnav-wrapper">
<div class="container">
<div class="plone-navbar-header">
<button type="button" class="plone-navbar-toggle" data-toggle="collapse" data-target="#portal-globalnav-collapse">
Expand Down
2 changes: 1 addition & 1 deletion plone/app/layout/viewlets/toolbar.pt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<img alt="Plone Toolbar" tal:attributes="src view/get_toolbar_logo" />
</a>
<a class="plone-toolbar-switcher" tal:condition="view/show_switcher"><span>Left-Top switcher</span></a>
<nav role="navigation">
<nav>
<ul class="plone-toolbar-main">
<div tal:replace="structure view/base_render">
</div>
Expand Down

0 comments on commit 351e0b7

Please sign in to comment.