[Superceeded] Rework sitemap.xml.gz view to fix it for plone.app.multilingual [master] #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ply such a filter if LinguaPlone is installed. The filter could (and probably should) be moved to LinguaPlone, but this is an improvement on previous code that assumed LinguaPlone was the only multilingual addon for Plone
djowett
added
22 status: in-progress
99 tag: Plone 5.x
25 status: deferred
and removed
22 status: in-progress
labels
|
Just realised that p.a.multilingual is tested against Plone 5.0, not Plone 5.1, so I need to work changes into plone.app.layout 2.5.x branch rather than master. |
|
I stand corrected - p.a.multilingual is tested against Plone 5.1 (as well as Plone 5.0) at least on Jenkins if not on Travis. So I do need this PR |
|
Unable to reopen this after a force-push, recreating as #110 |
djowett
changed the title
talarias
pushed a commit
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel #92 on 2.3.x branch