-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a surrounding div to the plone.analytics viewlet [2.3] #219
Conversation
@erral thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
I am not sure if it is a good idea to change markup in Plone 4.3 these days. Other opinions? |
I did this because it was explicitly requested by @idgserpro
<https://github.com/idgserpro> but I am fine if we leave Plone 4.3 as it is
right now.
…On Wed, Oct 9, 2019 at 11:09 AM Jens W. Klein ***@***.***> wrote:
I am not sure if it is a good idea to change markup in Plone 4.3 these
days. Other opinions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#219?email_source=notifications&email_token=AAGHRVOBB3R4JOCKB76CN4LQNWNULA5CNFSM4I6AMKVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAXGPGA#issuecomment-539912088>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGHRVMW5BZGT3GEX2SS3M3QNWNULANCNFSM4I6AMKVA>
.
--
Mikel Larreategi
CodeSyntax
Azitain industrialdea, 3-K - Eibar
Tfnoa.: +34 943821780
|
I see no problem adding tests in Plone 4.3. Probably the tests are failing not because of the implementation in this PR. |
It's up to you and the release managers if this is doable. Reading #157, if someone is using an implementation adding a id to the script tag, it will still work; And if it's not using it, In this scenario, we see no harm even in Plone 4.3.x, but some integrators may have a different opinion. |
@idgserpro ok, I am a bit super-careful here. If you think it wont break, ok. But first tests need to go green. |
I agree. I'm just not sure they are really related to this change: we're having 59 errors in https://jenkins.plone.org/job/pull-request-4.3/18/#showFailuresLink @erral maybe creating a new PR just changing a text file from https://github.com/plone/plone.app.layout/tree/2.3.x would show if these failures are really related to this change? |
I have re-run the PR Jenkins job |
@mauritsvanrees Since you've been the one responsible to give us Plone 4.3.19, do you think the changes here are ok, even changing the markup? |
I tried it in the Plone 4.3 site of a customer, which uses a lot of Diazo. The result is that the snippet is lost: apparently the Diazo rules of this site cannot handle the change. That can be fixed in the theme of this site of course, but I don't want to force users of Plone 4.3 sites to check this and fix their themes. Or more likely: to discover after several months that no analytics have been gathered. I see the possible use case, but for Plone 4.3 I would not do this. |
Fixes #157 in Plone 4.3.x
@laulaz @idgserpro