Add a surrounding div to the plone.analytics viewlet [master]

news/157.feature

@@ -0,0 +1,2 @@
+Add a sorrounding div to the webstats js. Fixes #157
+[erral]

plone/app/layout/analytics/tests/analytics.txt

@@ -33,3 +33,8 @@ Now enter some non-ascii text
     >>> text = manager.render()
     >>> site_settings.webstats_js in text
     True
+
+Check if the div sorrounding the script is present
+
+    >>> 'id="plone-analytics"' in text
+    True

plone/app/layout/analytics/view.pt

@@ -0,0 +1,8 @@
+<div
+  id="plone-analytics"
+  tal:condition="view/webstats_js"
+  tal:content="structure view/webstats_js"
+>
+  Here goes the webstats_js
+</div>
+

plone/app/layout/analytics/view.py

@@ -2,6 +2,7 @@
 from plone.registry.interfaces import IRegistry
 from Products.CMFPlone.interfaces import ISiteSchema
 from Products.Five.browser import BrowserView
+from Products.Five.browser.pagetemplatefile import ViewPageTemplateFile
 from zope.component import getUtility
 from zope.interface import implementer
 from zope.viewlet.interfaces import IViewlet
@@ -10,25 +11,24 @@
 @implementer(IViewlet)
 class AnalyticsViewlet(BrowserView):
 
+    render = ViewPageTemplateFile('view.pt')
+
     def __init__(self, context, request, view, manager):
         super(AnalyticsViewlet, self).__init__(context, request)
         self.__parent__ = view
         self.context = context
         self.request = request
         self.view = view
         self.manager = manager
+        self.webstats_js = ''
 
     def update(self):
-        pass
-
-    def render(self):
         """render the webstats snippet"""
         registry = getUtility(IRegistry)
         site_settings = registry.forInterface(
             ISiteSchema, prefix="plone", check=False)
         try:
             if site_settings.webstats_js:
-                return site_settings.webstats_js
+                self.webstats_js = site_settings.webstats_js
         except AttributeError:
             pass
-        return ''