Make sitemap.xml.gz work in a LinguaPlone environment #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from the query parameter
|
This sounds like a LinguaPlone bug to me...if it needs to modify the query that is passed in, it seems like it should make a copy rather than changing it in place. |
|
Mmmmm, could be yes. I'll check it. |
|
It looks like a wanted feature in LinguaPlone, it's in fact tested :O |
|
Okay, this fix is fine then. |
erral
added a commit
that referenced
this pull request
Sep 13, 2012
This was referenced May 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinguaPlone deletes Language parameter from the query, so when calling the catalog for the second time it is not present in the parameters so LinguaPlone uses current users language to get the content for the sitemap which is wrong.
More information:
1b03450#L2R44