Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check any reference in delete confirmation dialog #52

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

thet
Copy link
Member

@thet thet commented Apr 4, 2017

Support for any zc.relation refercences being checked by delete_confirmation_info dialog, not only references linked in text.

/cc @jensens @mauritsvanrees

Support for any ``zc.relation`` refercences being checked by ``delete_confirmation_info`` dialog, not only references linked in text.
Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mauritsvanrees mauritsvanrees merged commit 36f777c into master Apr 4, 2017
@mauritsvanrees mauritsvanrees deleted the thet-anyreference branch April 4, 2017 21:25
@pbauer
Copy link
Member

pbauer commented Apr 4, 2017

@thet this change needs to be reflected in the docs. So far the README says : "Whenever an object that is referred to by another one via an or tag is going to be deleted, a confirmation form is presented to the user." This in no longer true. Also it should also mention what happens (I think z3c.relationfield.event.breakRelations is called).

@thet
Copy link
Member Author

thet commented Apr 5, 2017

@pbauer : #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants