Skip to content

Commit

Permalink
Fixed html validation: bad value menu for attribute role on element s…
Browse files Browse the repository at this point in the history
…ection.

This is in the footer actions portlet, which contains links to
Sitemap, Accessibility, and Contact.

Also, when the header is not shown, you get this warning:
Section lacks heading.

Also, when the header *is* shown, we get an error:
The element 'header' must not appear as a descendant of the 'footer' element.

Also, the section with class portletContent is always lacking a header.

Solutions in this fix:
- Removed the role from this section.
- Changed all sections to divs.
  • Loading branch information
mauritsvanrees committed Mar 2, 2016
1 parent 26f455f commit 0fbff88
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions plone/app/portlets/portlets/actions.pt
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
tal:omit-tag=""
i18n:domain="plone">

<section class="portlet portletActions" role="menu"
<aside class="portlet portletActions"
tal:define="portal_url context/@@plone_portal_state/portal_url;">

<header class="portletHeader" tal:condition="view/showTitle">
<div class="portletHeader" tal:condition="view/showTitle">
<span tal:condition="view/title" tal:content="view/title">
Title
</span>
</header>
<section class="portletContent">
</div>
<div class="portletContent">
<ul>
<tal:loop tal:repeat="link view/actionLinks">
<li class="portletItem"
Expand All @@ -39,6 +39,6 @@
</li>
</tal:loop>
</ul>
</section>
</section>
</div>
</aside>
</html>

0 comments on commit 0fbff88

Please sign in to comment.