Ticket11189 #3
Merged
Ticket11189 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the remote URL for the href of Link objects if the user is not the author. Depends on Products.CMFPlone
|
would it be possible to have some similar test as here: https://github.com/plone/Products.CMFPlone/pull/5/files#L2R667 |
|
I did add a test, see fulv@1c081b5 |
|
my bad. i'll give it a closer look later today and merge it. |
|
as well cherry picked into 2.1 branch (plone 4.1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://dev.plone.org/ticket/11189
This fixes the nav portlet scenario of the above ticket. It needs to be pulled along with a patch to Products.CMFPlone, which I'm going to submit next.
These are the other pull requests that go with this one:
plone/Products.CMFPlone#5
plone/buildout.coredev#20