Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading portal message #85

Merged
merged 2 commits into from
May 20, 2024
Merged

Fix misleading portal message #85

merged 2 commits into from
May 20, 2024

Conversation

gforcada
Copy link
Member

Probably a copy and paste error?

But that's a scary one! When you cancel the deleting, it still says that it deleted it!

gforcada added 2 commits May 16, 2024 11:01
Probably a copy and paste error?

But that's a scary one! When you cancel the deleting, it still says that it deleted it!
@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need a status message here at all? Anyway, good catch

@davisagli
Copy link
Member

@jenkins-plone-org please run jobs

@gforcada gforcada merged commit f4fd4b4 into master May 20, 2024
14 checks passed
@gforcada gforcada deleted the gforcada-patch-1 branch May 20, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants