Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports are Python3 compatible #70

Merged
merged 4 commits into from
Feb 6, 2018
Merged

Imports are Python3 compatible #70

merged 4 commits into from
Feb 6, 2018

Conversation

b4oshany
Copy link
Contributor

No description provided.

Copy link
Member

@tomgross tomgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don’t you use six for this?

@davilima6 davilima6 force-pushed the py3_imports branch 4 times, most recently from bd9e48d to 7bab66e Compare January 30, 2018 22:20
@davilima6
Copy link
Member

davilima6 commented Jan 31, 2018

Failed with http://jenkins.plone.org/job/pull-request-5.2/316/

    Traceback (most recent call last):
      File "/usr/lib/python2.7/doctest.py", line 1315, in __run
        compileflags, 1) in test.globs
      File "<doctest layers.rst[110]>", line 1, in <module>
        runner.setup_layer(options, layers.PLONE_FTP_SERVER, setupLayers)
      File "/home/jenkins/.buildout/eggs/zope.testrunner-4.8.1-py2.7.egg/zope/testrunner/runner.py", line 765, in setup_layer
        setup_layer(options, base, setup_layers)
      File "/home/jenkins/.buildout/eggs/zope.testrunner-4.8.1-py2.7.egg/zope/testrunner/runner.py", line 770, in setup_layer
        layer.setUp()
      File "/home/jenkins/workspace/pull-request-5.2/src/plone.testing/src/plone/testing/z2.py", line 983, in setUp
        self.setUpServer()
      File "/home/jenkins/workspace/pull-request-5.2/src/plone.testing/src/plone/testing/z2.py", line 1100, in setUpServer
        logger_object=zopeLog)
      File "/home/jenkins/.buildout/eggs/ZServer-4.0b1-py2.7.egg/ZServer/FTPServer.py", line 635, in __init__
        ftp_server.__init__(self, None, *args, **kw)
      File "/home/jenkins/.buildout/eggs/ZServer-4.0b1-py2.7.egg/ZServer/medusa/ftp_server.py", line 716, in __init__
        self.bind((self.ip, self.port))
      File "/usr/lib/python2.7/asyncore.py", line 342, in bind
        return self.socket.bind(addr)
      File "/usr/lib/python2.7/socket.py", line 228, in meth
        return getattr(self._sock,name)(*args)
    error: [Errno 98] Address already in use

Retrying...

@davilima6
Copy link
Member

@davilima6 davilima6 requested a review from jensens January 31, 2018 09:17
Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jensens jensens merged commit 4fcdfca into master Feb 6, 2018
@jensens jensens deleted the py3_imports branch February 6, 2018 09:58
@davilima6
Copy link
Member

davilima6 commented Feb 6, 2018

Thanks! I updated plone/Products.CMFPlone#2217 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants