Port to Python 3 #49
Merged
Port to Python 3 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of plone.testing.
mauritsvanrees
approved these changes
May 18, 2018
| """ | ||
| setHooks() | ||
| site = getSite() | ||
|
|
||
| with z2.zopeApp(db, connection, environ) as app: | ||
| with getattr(flavour, 'zopeApp')(db, connection, environ) as app: |
There was a problem hiding this comment.
I would say either use flavour.zopeApp directly, or use getattr and explicitly handle the case that it falls back to None.
CHANGES.rst
Outdated
| Bug fixes: | ||
|
|
||
| - *add item here* | ||
| - *none yet* |
There was a problem hiding this comment.
Minor nitpick: if you keep * add item * here, then plone.releaser can automatically remove it on release, which is what you want here. If you add any other text, then plone.releaser does not touch it.
| Set up plone.testing.z2.Startup in ... seconds. | ||
| Set up plone.app.testing.layers.PloneFixture in ... seconds. | ||
| >>> runner.setup_layer(options, layers.PLONE_FIXTURE, setupLayers) # doctest: +ELLIPSIS | ||
| Set up plone.testing.zca.LayerCleanup in ... seconds. |
There was a problem hiding this comment.
Is the extra two space indentation intentional?
…d. Porting all tests away from PloneTestCase seems less work that migrating the layer and fixing the tests.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires that the
py3branch ofplone.testingis merged. So It cannot be tested separately against coredev on Jenkins. See plone/buildout.coredev#480 for a test running bothpy3branches.