Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dx siteroot #60

Merged
merged 11 commits into from
Aug 18, 2021
Merged

Dx siteroot #60

merged 11 commits into from
Aug 18, 2021

Conversation

jaroel
Copy link
Member

@jaroel jaroel commented Apr 6, 2019

No description provided.

@mister-roboto
Copy link

@jaroel thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@coveralls
Copy link

coveralls commented Feb 24, 2020

Coverage Status

Coverage decreased (-58.9%) to 0.0% when pulling f1ead80 on dx-siteroot into 5d36c61 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 58.244% when pulling 6983805 on dx-siteroot into e6e31a9 on master.

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently only has one line with a change. It seems to pass with current Plone 6 as well, so could be merged separately (but that should be tested on Jenkins to be sure).

A changelog entry is missing, but for such a small change in the tests, this is fine.
I sometimes want to release a package with such small changes anyway, but then I can quickly add a news item myself.

@mauritsvanrees
Copy link
Member

@jenkins-plone-org please run jobs

1 similar comment
@mauritsvanrees
Copy link
Member

@jenkins-plone-org please run jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants