-
-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Tell Products.TinyMCE what the MIME type is, so it doesn't have to wo…
…rk it out.
- Loading branch information
Showing
2 changed files
with
4 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
668bfe9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TESTS PASSED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=97e90c89d1d143a4b15857e84d846d9c
[SUCCESS] kgs-plone.app.textfield-plone-4.3-python-2.6 kgs
[SUCCESS] kgs-plone.app.textfield-plone-4.3-python-2.7 kgs
[SUCCESS] kgs-plone.app.textfield-plone-5.0-python-2.7 kgs
668bfe9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jensens @lentinj Seems like your commit/pull request broke the 4.3 build: http://jenkins.plone.org/job/plone-4.3-python-2.6/2384/#showFailuresLink
@bloodbare Please please disable the KGS github notifications! This is highly confusing for people. This commit broke the build but mr.roboto is telling us that everything is fine.
668bfe9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all is fine here, it was a different commit afaict see plone/plone.app.blob#10 which was reverted
668bfe9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be great if we can have a test for each PR branch with the whole current coredev on jenkins. This is something which would be ok to trigger manually to save resources.
the current situation is: local tests are very difficult to get to fly (esp. because of issues with selenium and current ff/chrome). So the only possibility is to merge and watch if theres red smoke.
668bfe9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooo, definitely. If one could make a comment to mister-roboto to trigger testing of that pull request, that would be very nice.