Skip to content

Commit

Permalink
Tell Products.TinyMCE what the MIME type is, so it doesn't have to wo…
Browse files Browse the repository at this point in the history
…rk it out.
  • Loading branch information
lentinj committed Sep 23, 2014
1 parent 94c649a commit 668bfe9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions docs/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ Changelog
1.2.4 (unreleased)
------------------

* Tell Products.TinyMCE what the MIME type is, so it doesn't have to work it out.
[lentinj]

- Use closest_content to navigate through the sea of subforms to
find something that we can use portal_url on.
[lentinj]
Expand Down
1 change: 1 addition & 0 deletions plone/app/textfield/widget_input.pt
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
here nocall:context;
portal_url nocall:context/portal_url;
portal portal_url/getPortalObject;
text_format view/value/mimeType | view/field/default_mime_type;
inputname view/name;
inputvalue view/value/raw | nothing;
here_url request/getURL;
Expand Down

5 comments on commit 668bfe9

@mister-roboto
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTS PASSED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=97e90c89d1d143a4b15857e84d846d9c
[SUCCESS] kgs-plone.app.textfield-plone-4.3-python-2.6 kgs
[SUCCESS] kgs-plone.app.textfield-plone-4.3-python-2.7 kgs
[SUCCESS] kgs-plone.app.textfield-plone-5.0-python-2.7 kgs

@tisto
Copy link
Member

@tisto tisto commented on 668bfe9 Sep 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jensens @lentinj Seems like your commit/pull request broke the 4.3 build: http://jenkins.plone.org/job/plone-4.3-python-2.6/2384/#showFailuresLink

@bloodbare Please please disable the KGS github notifications! This is highly confusing for people. This commit broke the build but mr.roboto is telling us that everything is fine.

@jensens
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all is fine here, it was a different commit afaict see plone/plone.app.blob#10 which was reverted

@jensens
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great if we can have a test for each PR branch with the whole current coredev on jenkins. This is something which would be ok to trigger manually to save resources.
the current situation is: local tests are very difficult to get to fly (esp. because of issues with selenium and current ff/chrome). So the only possibility is to merge and watch if theres red smoke.

@lentinj
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo, definitely. If one could make a comment to mister-roboto to trigger testing of that pull request, that would be very nice.

Please sign in to comment.