Fix transform #49
Merged
Fix transform #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jensens had to delete and re-add the branch and pull request, but here goes, rebased on master:) |
|
i see a test failure regarding an overlay. This could potentially have somerhing to do with my fix. Lets wait with the merge until i can investigate. |
|
Where do we stand on this one? |
|
…when the result is not html / is empty.
|
I rebased and pushed to my branch |
|
again after rebase http://jenkins.plone.org/job/pull-request-5.0/70/ |
jensens
added
pr testing
24 status: ready
and removed
35 needs: rebase
22 status: in-progress
pr testing
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix AttributeError: 'NoneType' object has no attribute 'getroottree' when the result is not html / is empty.