-
-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add Products.CMFPlacefulWorkflow as dep as __init__ requires this
- Loading branch information
1 parent
bd704bf
commit 0da7c6c
Showing
2 changed files
with
4 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0da7c6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maartenkling Were you having the same traceback as the one in plone/buildout.jenkins#20?
0da7c6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idgserpro Correct!
0da7c6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests using buildout-jenkins are breaking when using "bin/buildout -c jenkins.cfg -n && bin/jenkins-test", at least in our internal CI servers. Do you think it would be the case to create a new release of plone.app.upgrade, 1.3.11? Without this release we need to add
Products.CMFPlacefulWorkflow
in all of our packages in our CI infra-structure to make it work.Anyways, thanks for the fix!
0da7c6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes my tests are failing aswel, we need a new release and a repin in or the default test setup or a 4.3.7 release
0da7c6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will at least reference this commit in our fixes. Thanks for the clarification!