Skip to content

Commit

Permalink
add Products.CMFPlacefulWorkflow as dep as __init__ requires this
Browse files Browse the repository at this point in the history
  • Loading branch information
maartenkling committed Jun 17, 2015
1 parent bd704bf commit 0da7c6c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ Changelog
1.3.11 (unreleased)
-------------------

- add Products.CMFPlacefulWorkflow as dep as __init__ requires this
[maartenkling]

- add social media control panel upgrade
[vangheem]

Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
'Products.CMFDiffTool',
'Products.CMFEditions',
'Products.CMFFormController',
'Products.CMFPlacefulWorkflow',
'Products.CMFQuickInstallerTool',
'Products.CMFUid',
'Products.DCWorkflow',
Expand Down

5 comments on commit 0da7c6c

@idgserpro
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maartenkling Were you having the same traceback as the one in plone/buildout.jenkins#20?

@maartenkling
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idgserpro Correct!

@idgserpro
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests using buildout-jenkins are breaking when using "bin/buildout -c jenkins.cfg -n && bin/jenkins-test", at least in our internal CI servers. Do you think it would be the case to create a new release of plone.app.upgrade, 1.3.11? Without this release we need to add Products.CMFPlacefulWorkflow in all of our packages in our CI infra-structure to make it work.

Anyways, thanks for the fix!

@maartenkling
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes my tests are failing aswel, we need a new release and a repin in or the default test setup or a 4.3.7 release

@idgserpro
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will at least reference this commit in our fixes. Thanks for the clarification!

Please sign in to comment.