Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow figcaption in rich text editor as a valid tag. #209

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Conversation

thet
Copy link
Member

@thet thet commented Jun 19, 2019

@mister-roboto
Copy link

@thet thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

Allow ``figcaption`` in rich text editor as a valid tag.
Add registry setting for plone.image_caption outputfilter transform.
@davilima6
Copy link
Member

@jenkins-plone-org please run jobs

@thet
Copy link
Member Author

thet commented Feb 11, 2020

Not necessary anymore since: plone/Products.CMFPlone#2976

@thet thet closed this Feb 11, 2020
@thet thet deleted the thet-figcaption branch February 11, 2020 15:48
@thet thet restored the thet-figcaption branch February 17, 2020 14:09
@thet thet reopened this Feb 17, 2020
@mister-roboto
Copy link

@thet thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@thet
Copy link
Member Author

thet commented Feb 17, 2020

Actually needed for plone/Products.CMFPlone#2887
I closed it previously because I thought it's for plone/plone.staticresources#30 without checking...

@thet thet merged commit 3e1efd1 into master Feb 17, 2020
@thet thet deleted the thet-figcaption branch February 17, 2020 14:14
thet added a commit that referenced this pull request Feb 17, 2020
thet added a commit that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants