Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect @@historyview with Modify portal content permission #254

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Aug 11, 2021

@mister-roboto
Copy link

@pbauer thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@pbauer
Copy link
Member Author

pbauer commented Aug 11, 2021

@jenkins-plone-org please run jobs

@pbauer
Copy link
Member Author

pbauer commented Aug 11, 2021

@jenkins-plone-org please run jobs

@pbauer
Copy link
Member Author

pbauer commented Aug 11, 2021

The test-failure is unrelated.

@pbauer pbauer merged commit addce9e into master Aug 11, 2021
@pbauer pbauer deleted the protect_historyview_3297 branch August 11, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change permission of @@historyview
2 participants