Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dx siteroot #256

Merged
merged 5 commits into from
Sep 11, 2021
Merged

Dx siteroot #256

merged 5 commits into from
Sep 11, 2021

Conversation

mauritsvanrees
Copy link
Member

Part of the dexterity site root PLIP.
The coding was done by @ale-rt but I did not see a PR.
The code seems good to me, and it works on a small test site.

@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

news/0000.breaking Outdated Show resolved Hide resolved
Copy link
Member

@tisto tisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ale-rt
Copy link
Member

ale-rt commented Sep 7, 2021

I started the jenkin jobs using the following parameters:

https://github.com/plone/Products.CMFPlone/pull/2612
https://github.com/plone/plone.app.contenttypes/pull/475
https://github.com/plone/plone.app.upgrade/pull/256

@mauritsvanrees mauritsvanrees merged commit c3f6407 into master Sep 11, 2021
@jensens jensens deleted the dx-siteroot branch November 18, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants