Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give DX Site Root of existing sites an UUID. #258

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

jensens
Copy link
Member

@jensens jensens commented Sep 24, 2021

Seems missing in plone/Products.CMFPlone#2454

Remark: In new sites there is a subscriber in plone.uuid adding the attribute. After migration it seems this was not triggered and need manual intervention here.

related: plone/Products.CMFPlone#3312

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@jensens
Copy link
Member Author

jensens commented Sep 24, 2021

@jenkins-plone-org please run jobs

@jensens jensens marked this pull request as ready for review September 24, 2021 13:01
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works. Thanks.

@mauritsvanrees mauritsvanrees merged commit 8e1ec78 into master Sep 27, 2021
@mauritsvanrees mauritsvanrees deleted the fix-siteroot-uuid branch September 27, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants