Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For user schemas use a volatile cache on the request instead of on the portal. #114

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

mauritsvanrees
Copy link
Member

This prevents seeing an empty user profile when you have custom user schemas.
This fixes #76.
Includes two regression tests, although one of them already passes with the original code.

It's a bit ugly, but then the original code was ugly as well. There may be nicer ways to solve this, but I think such a solution would be a more drastic overhaul, and I would like to avoid that.

Actually, with the current code, test_regression_76_user_information fails and test_regression_76_personal_information passes.
With manual testing in a site, they both fail.
…e portal.

This prevents seeing an empty user profile when you have custom user schemas.
This fixes #76.
@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Member Author

@jenkins-plone-org please run jobs

@jensens jensens merged commit e32d33a into master Oct 31, 2022
@jensens jensens deleted the maurits-issue-76-empty-user-profile branch October 31, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Profile sometimes appears empty
3 participants