Apply hotfix 20160830 master #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies PloneHotfix20160830.
mauritsvanrees
added
23 status: testing
01 type: bug
12 prio: high
32 needs: review
24 status: ready
and removed
23 status: testing
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds something that is not in the hotfix: when the userid that is given in the request does not exist, raise a 404 NotFound error.
The master branch is for Plone 5. On Plone 4.3 the current behavior is that you get an AttributeError. That made 4.3 not vulnerable to this part of the hotfix. I intend to raise a 404 on 4.3 too.