Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort viewlets on export #8

Merged
merged 1 commit into from
Mar 5, 2015
Merged

Sort viewlets on export #8

merged 1 commit into from
Mar 5, 2015

Conversation

gforcada
Copy link
Member

@gforcada gforcada commented Mar 4, 2015

Fixes: #7

@gforcada
Copy link
Member Author

gforcada commented Mar 4, 2015

Sorry I mistakenly pushed that directly to master. I reverted it right away though.

@jensens
Copy link
Member

jensens commented Mar 5, 2015

Sorry, I dont get it, I try to to explain:

  1. We have here a viewlet manager which has some explicit order, i.e. logo, search, breadcrumbs.
  2. On import viewlets are created in this order.
  3. On export they got ordered alphabetically? So in XML the above example is breadcrumbs, logo, search.
  4. On import of the exported xml file the viewlet manager get configured with a order of breadcrumbs, logo, search.

So IOW, after export-import cycle viewlets are in a different order?

What do I miss?

@davisagli
Copy link
Member

It's sorting the managers so they are printed in a stable order in the xml; it's not doing anything to the order of viewlets within a manager.

@jensens
Copy link
Member

jensens commented Mar 5, 2015

omg, ok, sorry. so, why not pressing the green merge button then?

@gforcada
Copy link
Member Author

gforcada commented Mar 5, 2015

Sorry for not wording it clear enough. I would have pressed the green button myself but as I had to change the tests I preferred to way for someone to give me an ack that the changes on the test are fine.

So anyway willing to put a 👍 on it? :)

davisagli added a commit that referenced this pull request Mar 5, 2015
@davisagli davisagli merged commit 41dfe3c into plone:master Mar 5, 2015
@davisagli
Copy link
Member

@gforcada please add a changelog entry on master

@gforcada
Copy link
Member Author

gforcada commented Mar 5, 2015

Done on 9aaea9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort viewlet managers on export
3 participants