fix returning of item_id if given.

plone · Aug 18, 2022 · 37e421f · 37e421f
1 parent c1f3975
commit 37e421f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/news/16.bugfix b/news/16.bugfix
@@ -0,0 +1,3 @@
+Fix returning of item_id if given in `pretty_title_or_id`.
+Remove unused code and outdated comment.
+[jensens]
diff --git a/src/plone/base/utils.py b/src/plone/base/utils.py
@@ -185,6 +185,8 @@ def pretty_title_or_id(context, obj, empty_value=_marker):
     item_id = getattr(obj, "getId", None)
     if safe_callable(item_id):
         item_id = item_id()
+    if item_id is not None:
+        return item_id
     if empty_value is _marker:
         empty_value = get_empty_title(context)
     return empty_value