Improve check on created content ID

We need to check for container field / attribute when trying to create content with same id This refs #35
plone · Apr 18, 2023 · e736c4e · e736c4e
1 parent 853e76b
commit e736c4e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/news/35.bugfix b/news/35.bugfix
@@ -0,0 +1 @@
+Check for container field / attribute when trying to create content with same id [laulaz]
diff --git a/src/plone/base/utils.py b/src/plone/base/utils.py
@@ -506,6 +506,10 @@ def _check_for_collision(contained_by, cid, **kwargs):
                 mapping={"name": cid},
             )
 
+    # containers may have a field / attribute of the same name
+    if base_hasattr(contained_by, cid):
+        return _("${name} is reserved.", mapping={"name": cid})
+
     # containers may implement this hook to further restrict ids
     if getattr(aq_base(contained_by), "checkValidId", _marker) is not _marker:
         try:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Check for container field / attribute when trying to create content with same id [laulaz]