Fix uses of unrestrictedTraverse in get_top_site_from_url() #20
Conversation
… object cannot be found (a legitimate case), then it should not be considered as an object to return as ISite.
|
@Rudd-O thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
Dispatching the tests now: https://jenkins.plone.org/job/pull-request-6.0-3.10/32/console . |
|
Tests passed! https://jenkins.plone.org/job/pull-request-6.0-3.10/32/console @jenkins-plone-org please run jobs |
In some cases (when an object does not yet exist, for example) this method being called must skip these nonexistent objects from the recursive evaluation being done to discover the appropriate site to return.