Implementation of proposal #18 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pysailor
added a commit
to plone/plone.app.versioningbehavior
that referenced
this pull request
Feb 7, 2019
…edAttributes is called in all our uses cases. So if we fix that method to find the correct blob, we can handle all cases of changed dotted interface names. This commit depends on plone/plone.behavior#19
pysailor
added a commit
to plone/plone.app.versioningbehavior
that referenced
this pull request
Feb 7, 2019
…edAttributes is called in all our uses cases. So if we fix that method to find the correct blob, we can handle all cases of changed dotted interface names. This commit depends on plone/plone.behavior#19
1 task
pysailor
added a commit
to plone/plone.app.contenttypes
that referenced
this pull request
Feb 7, 2019
pysailor
added a commit
to plone/plone.app.contenttypes
that referenced
this pull request
Feb 8, 2019
…vior Follows #480 Depends on plone/plone.behavior#19
pysailor
force-pushed
the
18-former-dotted-names
branch
from
ec83247 to
b81907e
Compare
pysailor
added a commit
to plone/plone.app.contenttypes
that referenced
this pull request
Feb 8, 2019
…vior Follows #480 Depends on plone/plone.behavior#19
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Feb 8, 2019
Branch: refs/heads/master Date: 2019-02-08T15:29:58+01:00 Author: Wolfgang Thomas (pysailor) <thomas@syslab.com> Commit: plone/plone.app.contenttypes@7359717 Declare the former dotted name of the LeadImage and the RichText behavior Follows #480 Depends on plone/plone.behavior#19 Files changed: M plone/app/contenttypes/behaviors/configure.zcml Repository: plone.app.contenttypes Branch: refs/heads/master Date: 2019-02-08T15:34:58+01:00 Author: Wolfgang Thomas (pysailor) <thomas@syslab.com> Commit: plone/plone.app.contenttypes@6b96b5b update changelog Files changed: A news/480.bugfix Repository: plone.app.contenttypes Branch: refs/heads/master Date: 2019-02-08T17:21:56+01:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.contenttypes@5827048 Merge pull request #504 from plone/declare-old-dotted-name Declare the former name of the LeadImage behavior Files changed: A news/480.bugfix M plone/app/contenttypes/behaviors/configure.zcml
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Feb 9, 2019
Branch: refs/heads/master Date: 2019-02-07T14:25:36+01:00 Author: Wolfgang Thomas (pysailor) <thomas@syslab.com> Commit: plone/plone.app.versioningbehavior@038ab41 Work in progress: fix for #38 If a behavior that provides a NamedBlob field was renamed, the following will fail: - editing the current version of the content item - viewing a previous version (from the history) - reverting to a previous version This code is a proof of concept that fetches the blob from the stored history under its old name. It currently uses a hard-coded mapping that allows a lookup from old to new interface name. This needs to be turned into a utility lookup. Files changed: M plone/app/versioningbehavior/browser.py M plone/app/versioningbehavior/modifiers.py Repository: plone.app.versioningbehavior Branch: refs/heads/master Date: 2019-02-07T18:05:27+01:00 Author: Wolfgang Thomas (pysailor) <thomas@syslab.com> Commit: plone/plone.app.versioningbehavior@59a9a01 We can actually throw away lots of code again, since reattachReferencedAttributes is called in all our uses cases. So if we fix that method to find the correct blob, we can handle all cases of changed dotted interface names. This commit depends on plone/plone.behavior#19 Files changed: M plone/app/versioningbehavior/browser.py M plone/app/versioningbehavior/modifiers.py Repository: plone.app.versioningbehavior Branch: refs/heads/master Date: 2019-02-07T18:19:05+01:00 Author: Wolfgang Thomas (pysailor) <thomas@syslab.com> Commit: plone/plone.app.versioningbehavior@1c0098a add changelog entry Files changed: M CHANGES.rst Repository: plone.app.versioningbehavior Branch: refs/heads/master Date: 2019-02-08T01:01:12+01:00 Author: Wolfgang Thomas (pysailor) <thomas@syslab.com> Commit: plone/plone.app.versioningbehavior@fed6886 Not all named file fields are provided via a behavior... Files changed: M plone/app/versioningbehavior/modifiers.py Repository: plone.app.versioningbehavior Branch: refs/heads/master Date: 2019-02-09T11:17:17+01:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.versioningbehavior@1328716 Merge pull request #45 from plone/pysailor-namedfile Recover from renamed behavior Files changed: M CHANGES.rst M plone/app/versioningbehavior/modifiers.py
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Feb 9, 2019
Branch: refs/heads/master Date: 2019-02-07T14:25:36+01:00 Author: Wolfgang Thomas (pysailor) <thomas@syslab.com> Commit: plone/plone.app.versioningbehavior@038ab41 Work in progress: fix for #38 If a behavior that provides a NamedBlob field was renamed, the following will fail: - editing the current version of the content item - viewing a previous version (from the history) - reverting to a previous version This code is a proof of concept that fetches the blob from the stored history under its old name. It currently uses a hard-coded mapping that allows a lookup from old to new interface name. This needs to be turned into a utility lookup. Files changed: M plone/app/versioningbehavior/browser.py M plone/app/versioningbehavior/modifiers.py Repository: plone.app.versioningbehavior Branch: refs/heads/master Date: 2019-02-07T18:05:27+01:00 Author: Wolfgang Thomas (pysailor) <thomas@syslab.com> Commit: plone/plone.app.versioningbehavior@59a9a01 We can actually throw away lots of code again, since reattachReferencedAttributes is called in all our uses cases. So if we fix that method to find the correct blob, we can handle all cases of changed dotted interface names. This commit depends on plone/plone.behavior#19 Files changed: M plone/app/versioningbehavior/browser.py M plone/app/versioningbehavior/modifiers.py Repository: plone.app.versioningbehavior Branch: refs/heads/master Date: 2019-02-07T18:19:05+01:00 Author: Wolfgang Thomas (pysailor) <thomas@syslab.com> Commit: plone/plone.app.versioningbehavior@1c0098a add changelog entry Files changed: M CHANGES.rst Repository: plone.app.versioningbehavior Branch: refs/heads/master Date: 2019-02-08T01:01:12+01:00 Author: Wolfgang Thomas (pysailor) <thomas@syslab.com> Commit: plone/plone.app.versioningbehavior@fed6886 Not all named file fields are provided via a behavior... Files changed: M plone/app/versioningbehavior/modifiers.py Repository: plone.app.versioningbehavior Branch: refs/heads/master Date: 2019-02-09T11:17:17+01:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.versioningbehavior@1328716 Merge pull request #45 from plone/pysailor-namedfile Recover from renamed behavior Files changed: M CHANGES.rst M plone/app/versioningbehavior/modifiers.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New option
former_dotted_namesthat allows to register the former name under which a behavior used to be registered. This can be useful to ensure a smooth transition in case a behavior's dotted name is changed.Refs: #18