Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config with default template 3f6d9cbf #24

Merged
merged 7 commits into from
Apr 13, 2023

Conversation

jensens
Copy link
Member

@jensens jensens commented Apr 12, 2023

No description provided.

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jensens jensens force-pushed the config-with-default-template-3f6d9cbf branch from 6cd7b9f to ba16e4f Compare April 12, 2023 12:41
@jensens
Copy link
Member Author

jensens commented Apr 12, 2023

@gforcada what is the magic spell to get the shared workflow from plone/meta in here?
("Expectus workflowus" did not work)

@jensens
Copy link
Member Author

jensens commented Apr 12, 2023

@jenkins-plone-org please run jobs

@gforcada
Copy link
Member

Yeah, I'm starting to not like it that much, is a bit hidden:

You have to go to https://github.com/organizations/plone/settings/actions scroll all the way down and on the three dots on the Testing required workflow, select update, on the next screen search for the repository and save 🪄

For pre-commit.ci you need to go to https://results.pre-commit.ci/ and add it as well.

Done it already 😄

@gforcada gforcada force-pushed the config-with-default-template-3f6d9cbf branch from ba16e4f to ad4de54 Compare April 12, 2023 21:50
@gforcada
Copy link
Member

@jenkins-plone-org please run jobs

@jensens jensens merged commit 89731e1 into master Apr 13, 2023
@jensens jensens deleted the config-with-default-template-3f6d9cbf branch April 13, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants