Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full varnish cache invalidation is prevented by hardcoded backlog=200 #11

Open
avoinea opened this issue Jun 6, 2018 · 0 comments
Open

Full varnish cache invalidation is prevented by hardcoded backlog=200 #11

avoinea opened this issue Jun 6, 2018 · 0 comments

Comments

@avoinea
Copy link
Member

avoinea commented Jun 6, 2018

Is there any good reason we have Queue maxsize hard-coded to 200?!

plone.cachepurging/plone/cachepurging/purger.py

Line 69 in 3e714aa

def __init__(self, factory=Connection, timeout=30, backlog=200,

plone.cachepurging/plone/cachepurging/purger.py

Line 169 in 3e714aa

self.queues[key] = queue_ = queue.Queue(self.backlog)

This limit is easily reached if you have a lot of related-items to invalidate, thus Varnish cache will be partially invalidated resulting in inconsistent content.

I think this should be set by default to 0 (infinity)
avoinea added a commit to eea/plone.cachepurging that referenced this issue Jun 6, 2018
@avoinea
Refs plone#11 - Set default purger backlog size to 0 (infinity)
b232111
@avoinea avoinea mentioned this issue Jun 6, 2018
Merged
jensens added a commit that referenced this issue Jul 16, 2018
@jensens
Merge pull request #12 from eea/master
b04190a 
Refs #11 - Set default purger backlog size to 0 (infinity)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@avoinea