Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write on read #3

Closed
wants to merge 2 commits into from
Closed

Write on read #3

wants to merge 2 commits into from

Conversation

gforcada
Copy link
Member

Superseedes #2

@jensens jensens mentioned this pull request Dec 4, 2015
Closed
@gforcada @jensens
Fix a write on read situation
acb0b1b 
If the context gets its first annotation it need to be marked as
safe to write.

The same goes for the annotations on the object.
@gforcada @jensens
Conditionally import safeWrite
3eca0e4
@jensens jensens added this to the Plone 5.0.x milestone Dec 4, 2015
@jensens
Copy link
Member

jensens commented Dec 4, 2015

fails in 5.0 , because some random TestRequest has no 'environ' attribute (expected by safeWrite).

@gforcada gforcada closed this Dec 13, 2015
@gforcada gforcada deleted the write-on-read branch December 13, 2015 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
04 type: enhancement 23 status: testing 32 needs: review
Projects
None yet
Milestone
Plone 5.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@gforcada @jensens