Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a write on read situation #4

Merged
merged 1 commit into from
Feb 25, 2016
Merged

Fix a write on read situation #4

merged 1 commit into from
Feb 25, 2016

Conversation

jensens
Copy link
Member

@jensens jensens commented Jan 3, 2016

see plone/buildout.coredev#150

If the context gets its first annotation it need to be marked as
safe to write.

The same goes for the annotations on the object.

@jensens
Copy link
Member Author

jensens commented Jan 3, 2016

merge together with other, see coredev4 above

@jensens
Copy link
Member Author

jensens commented Jan 3, 2016

tests in 4.3 may fail, see above, in 5.0 it should be fine

If the context gets its first annotation it need to be marked as
safe to write.

The same goes for the annotations on the object.
@mauritsvanrees
Copy link
Member

Running tests together with plone/plone.protect#39 here for Plone 5: http://jenkins.plone.org/job/pull-request-5.0/942/

mauritsvanrees added a commit that referenced this pull request Feb 25, 2016
Fix a write on read situation
@mauritsvanrees mauritsvanrees merged commit 5abe5c1 into master Feb 25, 2016
@mauritsvanrees mauritsvanrees deleted the write-on-read branch February 25, 2016 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants