Only keep already uploaded image when it is a POST request #38
Conversation
…t is a POST request. Fixes auto csrf error in site-controlpanel (plone/Products.CMFPlone#2628) and personal-information (plone/Products.CMFPlone#2709) page.
|
@mauritsvanrees thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
With a new request, we should instantiate a new widget and call update and extract on it. Otherwise for example a file_upload_id can linger from a previous call.
There was a small mistake on Python 2: we basically set 'got = want', which meant the doctests always passed...
|
@jenkins-plone-org please run jobs |
|
The Python 2 tests were passing but Python 3 was failing, and I discovered that this was because the Py23DocChecker normalizer class had an error which made all tests pass on Python 2... I fixed that. @thet Would you agree that your feature for keeping already uploaded files in case of a validation error, is only needed on POST requests, and can be switched off on other requests, like I do in this PR? |
Fixes auto csrf error in site-controlpanel (plone/Products.CMFPlone#2628) and personal-information (plone/Products.CMFPlone#2709) page.
Those two errors are gone when I revert to plone.formwidget.namedfile 2.0.5, so it is introduced by the new feature from PR #32 like @pbauer suspected.
When I see it correctly, that feature is only useful on POST requests. That is what this PR does.