Skip to content

Commit

Permalink
skip all tests in test_scaling_functional because of test-isolation i…
Browse files Browse the repository at this point in the history 
…ssues in py2
  • Loading branch information
@pbauer
pbauer committed Oct 1, 2018
1 parent fc1faab commit b82f13d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions plone/namedfile/tests/test_scaling_functional.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from zope.interface import implementer

import PIL
import six
import time
import transaction
import unittest
Expand Down Expand Up @@ -53,6 +54,8 @@ class ImagePublisherTests(unittest.TestCase):
layer = PLONE_NAMEDFILE_FUNCTIONAL_TESTING

def setUp(self):
if six.PY2:
raise unittest.SkipTest('Disabled in py2 for now.')
self.layer['zodbDB_before_namedfile'] = self.layer.get('zodbDB')
self.layer['zodbDB'] = zodb.stackDemoStorage(
self.layer.get('zodbDB'),
Expand Down

1 comment on commit b82f13d

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbauer Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.namedfile/100/violations

plone/namedfile/file.py:267:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/file.py:308:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/handler.py:11:23: C812 missing trailing comma
plone/namedfile/interfaces.py:17:25: C812 missing trailing comma
plone/namedfile/scaling.py:193:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:196:5: C901 'DefaultImageScalingFactory.__call__' is too complex (15)
plone/namedfile/scaling.py:203:25: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:243:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:407:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:434:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:446:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:460:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:486:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:500:17: C816 missing trailing comma in Python 3.6+
plone/namedfile/testing.py:5:1: I004 isort found an unexpected blank line in imports
plone/namedfile/testing.py:18:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/namedfile/tests/test_blobfile.py:40:31: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:45:35: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:50:46: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:55:32: C812 missing trailing comma
plone/namedfile/tests/test_doctests.py:26:17: Q000 Remove bad quotes.
plone/namedfile/tests/test_doctests.py:26:30: Q000 Remove bad quotes.
plone/namedfile/tests/test_doctests.py:47:10: C812 missing trailing comma
plone/namedfile/tests/test_image.py:25:80: E501 line too long (80 > 79 characters)
plone/namedfile/tests/test_scaling.py:85:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:102:80: E501 line too long (81 > 79 characters)
plone/namedfile/tests/test_scaling.py:133:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:156:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:178:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:200:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling_functional.py:62:36: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:130:28: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:160:70: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:167:76: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:178:74: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:211:75: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:216:78: C812 missing trailing comma
plone/namedfile/utils/__init__.py:84:66: C812 missing trailing comma
plone/namedfile/utils/__init__.py:151:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:156:73: C812 missing trailing comma
plone/namedfile/utils/__init__.py:176:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:183:18: C812 missing trailing comma
plone/namedfile/utils/__init__.py:188:1: C901 'rotate_image' is too complex (20)
plone/namedfile/utils/__init__.py:219:14: C812 missing trailing comma
plone/namedfile/utils/__init__.py:271:25: F821 undefined name 'StringIO'
plone/namedfile/utils/__init__.py:276:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils/__init__.py:280:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils/tiff_utils.py:11:1: C901 'process_tiff' is too complex (11)
plone/namedfile/utils/tiff_utils.py:20:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:81:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:82:7: T000 Todo note found.

Follow these instructions to reproduce it locally.

Please sign in to comment.