Skip to content

Commit

Permalink
Imports are Python3 compatible
Browse files Browse the repository at this point in the history
  • Loading branch information
ale-rt authored and jensens committed Oct 23, 2017
1 parent 6f1d946 commit ed0c45c
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 7 deletions.
3 changes: 3 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ New features:

Bug fixes:

- Imports are Python3 compatible
[ale-rt]

- remove mention of "retina" (https://github.com/plone/Products.CMFPlone/issues/2123)
[tkimnguyen]

Expand Down
2 changes: 1 addition & 1 deletion plone/namedfile/tests/test_scaling.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from plone.namedfile.testing import PLONE_NAMEDFILE_INTEGRATION_TESTING
from plone.namedfile.tests import getFile
from plone.scale.interfaces import IScaledImageQuality
from StringIO import StringIO
from six.StringIO import StringIO
from zExceptions import Unauthorized
from zope.annotation import IAttributeAnnotatable
from zope.component import getGlobalSiteManager
Expand Down
2 changes: 1 addition & 1 deletion plone/namedfile/tests/test_scaling_functional.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from plone.namedfile.testing import PLONE_NAMEDFILE_FUNCTIONAL_TESTING
from plone.namedfile.tests import getFile
from plone.testing.z2 import Browser
from StringIO import StringIO
from six.StringIO import StringIO
from zope.annotation import IAttributeAnnotatable
from zope.interface import implementer

Expand Down
3 changes: 1 addition & 2 deletions plone/namedfile/utils/__init__.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
# -*- coding: utf-8 -*-

from logging import getLogger
from plone.namedfile.interfaces import IBlobby
from plone.namedfile.utils.jpeg_utils import process_jpeg
from plone.namedfile.utils.png_utils import process_png
from plone.namedfile.utils.tiff_utils import process_tiff
from plone.registry.interfaces import IRegistry
from StringIO import StringIO
from six.StringIO import StringIO
from zope.component import queryUtility
from zope.deprecation import deprecate

Expand Down
2 changes: 1 addition & 1 deletion plone/namedfile/utils/jpeg_utils.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-

from logging import getLogger
from StringIO import StringIO
from six.StringIO import StringIO

import struct

Expand Down
3 changes: 1 addition & 2 deletions plone/namedfile/utils/tiff_utils.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# -*- coding: utf-8 -*-

from logging import getLogger
from StringIO import StringIO
from six.StringIO import StringIO

import struct

Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# -*- coding: utf-8 -*-
from setuptools import find_packages
from setuptools import setup

import os


Expand Down

1 comment on commit ed0c45c

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ale-rt Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.namedfile/62/violations

plone/namedfile/marshaler.py:67:36: C812 missing trailing comma
plone/namedfile/testing.py:18:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/namedfile/testing.py:22:36: C812 missing trailing comma
plone/namedfile/file.py:261:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/file.py:302:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/handler.py:11:23: C812 missing trailing comma
plone/namedfile/interfaces.py:17:25: C812 missing trailing comma
plone/namedfile/scaling.py:192:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:195:5: C901 'DefaultImageScalingFactory.__call__' is too complex (15)
plone/namedfile/scaling.py:202:25: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:242:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:406:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:433:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:445:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:459:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:485:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:499:17: C816 missing trailing comma in Python 3.6+
plone/namedfile/utils/__init__.py:83:66: C812 missing trailing comma
plone/namedfile/utils/__init__.py:150:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:155:73: C812 missing trailing comma
plone/namedfile/utils/__init__.py:175:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:182:18: C812 missing trailing comma
plone/namedfile/utils/__init__.py:187:1: C901 'rotate_image' is too complex (20)
plone/namedfile/utils/__init__.py:218:14: C812 missing trailing comma
plone/namedfile/utils/__init__.py:275:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils/__init__.py:279:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils/tiff_utils.py:11:1: C901 'process_tiff' is too complex (11)
plone/namedfile/utils/tiff_utils.py:20:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:81:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:82:7: T000 Todo note found.
plone/namedfile/tests/test_blobfile.py:40:31: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:45:35: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:50:46: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:55:32: C812 missing trailing comma
plone/namedfile/tests/test_scaling.py:85:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:102:80: E501 line too long (81 > 79 characters)
plone/namedfile/tests/test_scaling.py:133:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:156:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:178:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:200:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_doctests.py:25:51: C812 missing trailing comma
plone/namedfile/tests/test_doctests.py:27:10: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:116:28: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:146:70: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:153:76: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:164:74: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:197:75: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:202:78: C812 missing trailing comma

Follow these instructions to reproduce it locally.

Please sign in to comment.