Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests break with zope.interface 6.0.0 #8

Closed
mauritsvanrees opened this issue Mar 17, 2023 · 2 comments
Closed

Tests break with zope.interface 6.0.0 #8

mauritsvanrees opened this issue Mar 17, 2023 · 2 comments

Comments

@mauritsvanrees
Copy link
Member

Today Zope master updated zope.interface from 5.5.2 to 6.0.0. This leads to a test failure.
I have temporarily (?) pinned it to the old version in the coredev buildout.
See plone/buildout.coredev@4c16bb3 which also has the tracebacks.
@mauritsvanrees
Copy link
Member Author

Problem is only with latest Zope master, and for the moment we use the Zope 5.8.1 release, as I am preparing Plone 6.0.3.
But someone should fix this within a month or so.

mauritsvanrees referenced this issue in plone/buildout.coredev Mar 21, 2023
@mauritsvanrees
Temporarily pin back zope.interface to 5.5.2.
4c16bb3 
Or maybe do this permanently for Plone 6.0.
But it should only break for old code that no longer works anyway, using 'implements' and 'directlyProvides'.

See https://jenkins.plone.org/job/plone-6.0-python-3.11/527/testReport/junit/plone/portlets/uisupport_txt/

```
File "/home/jenkins/.buildout/eggs/cp311/plone.portlets-2.3.3-py3.11.egg/plone/portlets/uisupport.txt", line 19, in uisupport.txt
Failed example:
    from zope.interface import implements, Interface, directlyProvides
Exception raised:
    Traceback (most recent call last):
      File "/srv/python3.11/lib/python3.11/doctest.py", line 1350, in __run
        exec(compile(example.source, filename, "single",
      File "<doctest uisupport.txt[1]>", line 1, in <module>
        from zope.interface import implements, Interface, directlyProvides
    ImportError: cannot import name 'implements' from 'zope.interface' (/home/jenkins/.buildout/eggs/cp311/zope.interface-6.0-py3.11-linux-x86_64.egg/zope/interface/__init__.py)
----------------------------------------------------------------------
File "/home/jenkins/.buildout/eggs/cp311/plone.portlets-2.3.3-py3.11.egg/plone/portlets/uisupport.txt", line 50, in uisupport.txt
Failed example:
    directlyProvides(left, IFoo1)
Exception raised:
    Traceback (most recent call last):
      File "/srv/python3.11/lib/python3.11/doctest.py", line 1350, in __run
        exec(compile(example.source, filename, "single",
      File "<doctest uisupport.txt[20]>", line 1, in <module>
        directlyProvides(left, IFoo1)
    NameError: name 'directlyProvides' is not defined
```
@mauritsvanrees
Copy link
Member Author

Sigh, one test was importing implements but not actually using it... I fix it as part of PR #9.

mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Mar 28, 2023
@jensens
[fc] Repository: plone.portlets
c909a96 
Branch: refs/heads/master
Date: 2023-03-18T02:00:29+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.portlets@1498c97

Configuring with plone/meta

Files changed:
A .editorconfig
A .meta.toml
A .pre-commit-config.yaml
A news/80cf330f.internal
A tox.ini
M pyproject.toml
M setup.cfg
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-19T12:33:20+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.portlets@64fd679

chore: pyupgrade

Files changed:
M plone/portlets/assignable.py
M plone/portlets/interfaces.py
M plone/portlets/manager.py
M plone/portlets/registration.py
M plone/portlets/retriever.py
M plone/portlets/storage.py
M plone/portlets/tests.py
M plone/portlets/utils.py
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-19T12:33:38+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.portlets@ddb3e60

chore: isort

Files changed:
M plone/portlets/interfaces.py
M plone/portlets/tests.py
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-19T12:34:35+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.portlets@76dc3b2

chore: black

Files changed:
M plone/__init__.py
M plone/portlets/assignable.py
M plone/portlets/constants.py
M plone/portlets/interfaces.py
M plone/portlets/manager.py
M plone/portlets/registration.py
M plone/portlets/retriever.py
M plone/portlets/settings.py
M plone/portlets/storage.py
M plone/portlets/tests.py
M plone/portlets/utils.py
M setup.py
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-19T12:34:53+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.portlets@276f700

chore: zpretty

Files changed:
M plone/portlets/configure.zcml
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-19T12:38:40+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.portlets@b3a102e

feat: flake8

Files changed:
M plone/portlets/storage.py
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-19T12:41:37+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.portlets@8bfb29f

feat: codespell

Files changed:
M plone/portlets/README.txt
M plone/portlets/interfaces.py
M plone/portlets/tests.py
M plone/portlets/utils.txt
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-19T18:25:25+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.portlets@2e1ea5a

chore: require python 3.8

Files changed:
M setup.py
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-19T18:26:26+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.portlets@ec7ee02

feat: declare dependencies

Files changed:
M setup.py
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-28T12:00:54+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.portlets@c5c431e

Add zope.testing to test requires.

Otherwise test_portlet_metadata_availability fails with a ComponentLookupError.
Simply having the package available is enough, we don't need to call it.
So add it to the dependencies ignores.

Files changed:
M .meta.toml
M setup.py
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-28T12:02:41+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.portlets@8013be9

Configuring with plone/meta

Files changed:
A news/e380661b.internal
M .meta.toml
M .pre-commit-config.yaml
M pyproject.toml
M tox.ini
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-28T12:02:57+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.portlets@76977c6

quotes

Files changed:
M setup.py
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-28T12:03:56+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.portlets@e0c49d2

Remove duplicate news file after updating again.

Files changed:
D news/e380661b.internal
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-28T12:04:40+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.portlets@cb8883d

tox -e test: allow passing arguments.

For example: `tox -e test -- -D` to get a debug prompt after a test failure.

Files changed:
M tox.ini
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-28T12:10:01+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.portlets@e8bed76

Bumped version for breaking release.

Updated classifiers, added breaking news snippet.

Files changed:
A news/9.breaking
M setup.py
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-28T12:15:08+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.portlets@b32d092

Removed unused zope.interface imports from uisupport tests.

This fixes an incompatibility with the most recent zope.interface.
Fixes plone/plone.portlets#8

Files changed:
M plone/portlets/uisupport.txt
Repository: plone.portlets

Branch: refs/heads/master
Date: 2023-03-28T13:01:47+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.portlets@516fc19

Merge pull request #9 from plone/config-with-default-template-8b1d4add

Config with default template

Files changed:
A .editorconfig
A .meta.toml
A .pre-commit-config.yaml
A news/80cf330f.internal
A news/9.breaking
A tox.ini
M plone/__init__.py
M plone/portlets/README.txt
M plone/portlets/assignable.py
M plone/portlets/configure.zcml
M plone/portlets/constants.py
M plone/portlets/interfaces.py
M plone/portlets/manager.py
M plone/portlets/registration.py
M plone/portlets/retriever.py
M plone/portlets/settings.py
M plone/portlets/storage.py
M plone/portlets/tests.py
M plone/portlets/uisupport.txt
M plone/portlets/utils.py
M plone/portlets/utils.txt
M pyproject.toml
M setup.cfg
M setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mauritsvanrees