Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.6 and 3.7. #34

Merged
merged 10 commits into from
Dec 3, 2018
Merged

Add support for Python 3.6 and 3.7. #34

merged 10 commits into from
Dec 3, 2018

Conversation

icemac
Copy link

@icemac icemac commented Nov 29, 2018

No description provided.

Michael Howitz added 5 commits November 29, 2018 13:59
Fix tests for Python 2.7.
b02af7d
Test on Python 3+.
e577cb2 
When using buildout for the tests they break because zc.buildout does not seem to be installed.
Fix coverage testing + test coverage in subprocesses.
20e38b0
Fix Manifest.
8f133d8
Fix classifiers.
67d4663
@icemac icemac self-assigned this Nov 29, 2018
@icemac icemac requested review from esteele and tschorr November 29, 2018 13:05
sallner
sallner approved these changes Nov 30, 2018
View reviewed changes
Copy link
Member

@sallner sallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have only some minor comments.

tox.ini Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
src/plone/recipe/zeoserver/tests/zeoserver.txt Show resolved Hide resolved
src/plone/recipe/zeoserver/tests/test_docs.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
mauritsvanrees
mauritsvanrees approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Some Jenkins jobs fail, but those errors are unrelated (some unstable tests) or meanwhile solved (a widget test). I will merge.

@mauritsvanrees mauritsvanrees merged commit f888758 into master Dec 3, 2018
@mauritsvanrees mauritsvanrees deleted the py37 branch December 3, 2018 11:07
@icemac
Copy link
Author

icemac commented Dec 3, 2018

Thank you!

@icemac icemac mentioned this pull request Dec 3, 2018
Closed
@icemac
Copy link
Author

icemac commented Dec 3, 2018

@mauritsvanrees Can we have a release on PyPI please?

@mauritsvanrees
Copy link
Member

@icemac plone.recipe.zeoserver 2.0.0 released.

@sallner
Copy link
Member

sallner commented Dec 4, 2018

@mauritsvanrees Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sallner sallner sallner approved these changes

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

@esteele esteele Awaiting requested review from esteele

@tschorr tschorr Awaiting requested review from tschorr

Assignees

@icemac icemac

Labels
04 type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icemac @mauritsvanrees @sallner