Skip to content

Commit

Permalink
Avoid a deprecation warning
Browse files Browse the repository at this point in the history
  • Loading branch information
@gforcada
gforcada committed Nov 11, 2018
1 parent 3d5c54a commit 707c481
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ Bug fixes:
- Adapt test to changed object field in zope4
[pbauer]

- Avoid a deprecation warning that would turn into an error on Python 3.8.
[gforcada]

1.1.3 (2018-06-22)
------------------
Expand Down
2 changes: 1 addition & 1 deletion plone/registry/recordsproxy.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from UserDict import DictMixin
except ImportError:
from collections import UserDict
from collections import MutableMapping as DictMixin
from collections.abc import MutableMapping as DictMixin

if sys.version_info >= (3,):
basestring = str
Expand Down

1 comment on commit 707c481

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gforcada Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.registry/23/violations

plone/registry/recordsproxy.py:16:5: F401 'collections.UserDict' imported but unused
plone/registry/recordsproxy.py:33:34: Q000 Remove bad quotes.
plone/registry/recordsproxy.py:47:12: E111 indentation is not a multiple of four
plone/registry/recordsproxy.py:65:16: Q000 Remove bad quotes.
plone/registry/recordsproxy.py:67:43: C812 missing trailing comma
plone/registry/recordsproxy.py:75:28: Q000 Remove bad quotes.
plone/registry/recordsproxy.py:84:32: Q000 Remove bad quotes.
plone/registry/recordsproxy.py:102:29: C812 missing trailing comma
plone/registry/recordsproxy.py:133:30: C812 missing trailing comma
plone/registry/recordsproxy.py:151:19: C812 missing trailing comma
plone/registry/events.py:20:16: Q000 Remove bad quotes.
plone/registry/events.py:20:16: S001 found module formatter
plone/registry/tests.py:7:1: I001 isort found an import in the wrong position
plone/registry/tests.py:34:12: P002 found "hasattr", consider replacing it
plone/registry/tests.py:56:36: Q000 Remove bad quotes.
plone/registry/tests.py:56:60: Q000 Remove bad quotes.
plone/registry/tests.py:57:34: Q000 Remove bad quotes.
plone/registry/tests.py:64:15: Q000 Remove bad quotes.
plone/registry/tests.py:66:18: C812 missing trailing comma
plone/registry/tests.py:69:15: Q000 Remove bad quotes.
plone/registry/tests.py:70:29: C812 missing trailing comma
plone/registry/tests.py:107:40: Q000 Remove bad quotes.
plone/registry/tests.py:107:60: Q000 Remove bad quotes.
plone/registry/tests.py:148:34: Q000 Remove bad quotes.
plone/registry/tests.py:150:28: Q000 Remove bad quotes.
plone/registry/tests.py:152:36: Q000 Remove bad quotes.
plone/registry/tests.py:162:33: Q000 Remove bad quotes.
plone/registry/tests.py:163:67: Q000 Remove bad quotes.
plone/registry/tests.py:164:61: Q000 Remove bad quotes.
plone/registry/tests.py:178:44: C812 missing trailing comma
plone/registry/tests.py:186:44: C812 missing trailing comma
plone/registry/tests.py:194:44: C812 missing trailing comma
plone/registry/registry.py:24:1: I001 isort found an import in the wrong position
plone/registry/registry.py:25:1: I003 isort expected 1 blank line in imports, found 0
plone/registry/registry.py:60:11: T000 Todo note found.
plone/registry/registry.py:72:32: Q000 Remove bad quotes.
plone/registry/registry.py:79:25: Q000 Remove bad quotes.
plone/registry/registry.py:80:25: Q000 Remove bad quotes.
plone/registry/registry.py:82:33: C812 missing trailing comma
plone/registry/registry.py:83:26: C812 missing trailing comma
plone/registry/registry.py:95:32: Q000 Remove bad quotes.
plone/registry/registry.py:105:21: Q000 Remove bad quotes.
plone/registry/registry.py:106:21: Q000 Remove bad quotes.
plone/registry/registry.py:108:49: C812 missing trailing comma
plone/registry/registry.py:109:22: C812 missing trailing comma
plone/registry/registry.py:124:17: B901 blind except: statement
plone/registry/registry.py:130:32: C812 missing trailing comma
plone/registry/registry.py:141:20: C812 missing trailing comma
plone/registry/registry.py:175:9: Q000 Remove bad quotes.
plone/registry/registry.py:176:9: Q000 Remove bad quotes.
plone/registry/registry.py:177:9: Q000 Remove bad quotes.
plone/registry/registry.py:178:9: Q000 Remove bad quotes.
plone/registry/registry.py:180:9: Q000 Remove bad quotes.
plone/registry/registry.py:192:30: Q000 Remove bad quotes.
plone/registry/registry.py:291:21: Q000 Remove bad quotes.
plone/registry/registry.py:291:68: C812 missing trailing comma
plone/registry/registry.py:308:13: Q000 Remove bad quotes.
plone/registry/registry.py:309:13: Q000 Remove bad quotes.
plone/registry/registry.py:310:31: C812 missing trailing comma
plone/registry/interfaces.py:28:23: C812 missing trailing comma
plone/registry/interfaces.py:32:23: C812 missing trailing comma
plone/registry/interfaces.py:46:67: C812 missing trailing comma
plone/registry/interfaces.py:50:22: C812 missing trailing comma
plone/registry/interfaces.py:68:32: C812 missing trailing comma
plone/registry/interfaces.py:73:70: C812 missing trailing comma
plone/registry/interfaces.py:85:23: C812 missing trailing comma
plone/registry/interfaces.py:112:45: Q000 Remove bad quotes.
plone/registry/interfaces.py:118:22: C812 missing trailing comma
plone/registry/interfaces.py:122:61: C812 missing trailing comma
plone/registry/interfaces.py:195:22: C812 missing trailing comma
plone/registry/interfaces.py:208:22: C812 missing trailing comma
plone/registry/fieldfactory.py:35:30: Q000 Remove bad quotes.
plone/registry/fieldfactory.py:44:74: C812 missing trailing comma
plone/registry/fieldfactory.py:54:17: Q000 Remove bad quotes.
plone/registry/fieldfactory.py:55:17: Q000 Remove bad quotes.
plone/registry/fieldfactory.py:92:17: Q000 Remove bad quotes.
plone/registry/fieldfactory.py:93:17: Q000 Remove bad quotes.
plone/registry/__init__.py:2:1: F401 'plone.registry.fieldref.FieldRef' imported but unused
plone/registry/__init__.py:3:1: F401 'plone.registry.record.Record' imported but unused
plone/registry/__init__.py:4:1: F401 'plone.registry.registry.Registry' imported but unused
plone/registry/field.py:17:1: I001 isort found an import in the wrong position
plone/registry/field.py:59:13: Q000 Remove bad quotes.
plone/registry/field.py:60:13: Q000 Remove bad quotes.
plone/registry/field.py:60:43: C812 missing trailing comma
plone/registry/field.py:97:17: Q000 Remove bad quotes.
plone/registry/field.py:98:17: Q000 Remove bad quotes.
plone/registry/field.py:101:18: C812 missing trailing comma
plone/registry/field.py:124:42: C812 missing trailing comma
plone/registry/field.py:236:21: Q000 Remove bad quotes.
plone/registry/field.py:237:21: Q000 Remove bad quotes.
plone/registry/field.py:237:63: C812 missing trailing comma
plone/registry/field.py:242:17: Q000 Remove bad quotes.
plone/registry/field.py:243:17: Q000 Remove bad quotes.
plone/registry/field.py:243:75: C812 missing trailing comma
plone/registry/field.py:247:13: Q000 Remove bad quotes.
plone/registry/field.py:249:13: Q000 Remove bad quotes.
plone/registry/field.py:257:25: Q000 Remove bad quotes.
plone/registry/field.py:257:79: C812 missing trailing comma
plone/registry/record.py:28:16: Q000 Remove bad quotes.
plone/registry/record.py:34:30: Q000 Remove bad quotes.
plone/registry/record.py:115:16: Q000 Remove bad quotes.
plone/registry/record.py:115:16: S001 found module formatter

Follow these instructions to reproduce it locally.

Please sign in to comment.