Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report: when updating version, we should not push #32

Closed
mauritsvanrees opened this issue Mar 4, 2020 · 0 comments · Fixed by #33
Closed

Report: when updating version, we should not push #32

mauritsvanrees opened this issue Mar 4, 2020 · 0 comments · Fixed by #33
Assignees
@mauritsvanrees
Labels
01 type: bug

Comments

@mauritsvanrees
Copy link
Member

I ran bin/manage.py report --interactive today in 4.3 and 5.1. This was for finding missing checkouts. But this also found a few packages with newer versions. For example on 4.3:

Newer version 1.1.4 is available for Products.ZopeVersionControl (Currently 1.1.3)

I answered yes, plone.releaser commit the change, and... it immediately pushed. This included the version update and several added checkouts. I wanted to at least run bin/buildout before I pushed.

In this case, the updated version is a bad idea, because it pulls in too new versions of zope packages, and buildout fails. But the change was pushed already, and Jenkins broke. (I reverted the change of course.)

plone.releaser should ask if you want to push. I will make a PR.
@mauritsvanrees mauritsvanrees self-assigned this Mar 4, 2020
mauritsvanrees added a commit that referenced this issue Mar 4, 2020
@mauritsvanrees
Ask before pushing an updated version when running 'report'.
8e2f3d3 
Fixes #32
@mauritsvanrees mauritsvanrees mentioned this issue Mar 4, 2020
Merged
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Mar 5, 2020
@gforcada
[fc] Repository: plone.releaser
a3c7c75 
Branch: refs/heads/master
Date: 2020-03-04T17:19:15+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@8e2f3d3

Ask before pushing an updated version when running 'report'.

Fixes plone/plone.releaser#32

Files changed:
A news/32.bugfix
M plone/releaser/package.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2020-03-05T01:34:33+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.releaser@242fdf9

Merge pull request #33 from plone/maurits/issue-32-push-ask

Ask before pushing an updated version when running 'report'.

Files changed:
A news/32.bugfix
M plone/releaser/package.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Mar 5, 2020
@gforcada
[fc] Repository: plone.releaser
52a7bea 
Branch: refs/heads/master
Date: 2020-03-04T17:19:15+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@8e2f3d3

Ask before pushing an updated version when running 'report'.

Fixes plone/plone.releaser#32

Files changed:
A news/32.bugfix
M plone/releaser/package.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2020-03-05T01:34:33+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.releaser@242fdf9

Merge pull request #33 from plone/maurits/issue-32-push-ask

Ask before pushing an updated version when running 'report'.

Files changed:
A news/32.bugfix
M plone/releaser/package.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauritsvanrees mauritsvanrees

Labels
01 type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ask before pushing an updated version when running 'report'. plone/plone.releaser
1 participant
@mauritsvanrees