Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

versions2constraints should always preserve the case #65

Closed
mauritsvanrees opened this issue Mar 29, 2024 · 0 comments · Fixed by #66
Closed

versions2constraints should always preserve the case #65

mauritsvanrees opened this issue Mar 29, 2024 · 0 comments · Fixed by #66

Comments

@mauritsvanrees
Copy link
Member

In buildout.coredev branch 6.1 when you run bin/version2constraints the constraints* files get updated based on the versions* files. But all package names become lowercase. See for example `products.*.

This works, and could be fine, but I think it would be better to preserve the case.
Mostly I think we turned it into lowercase because I did not know how to preserve it. A key point there in, is that ConfigParser by default turns the keys into lowercase. But you can set config.optionxform = str to preserve the case.

We could decide to make everything lower case, but that should not be because a tool forces us, but because we choose it. Then we should make the package names in versions.cfg lowercase, and then all is fine.

But meanwhile, I am working to improve this.
mauritsvanrees added a commit that referenced this issue Mar 29, 2024
@mauritsvanrees
Preserve the case of package names in versions2constraints and friends.
c8c29e5 
Fixes #65
@mauritsvanrees mauritsvanrees mentioned this issue Mar 29, 2024
Merged
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Apr 2, 2024
@mauritsvanrees
[fc] Repository: plone.releaser
0cb5bb4 
Branch: refs/heads/master
Date: 2024-03-29T17:31:39+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@c8c29e5

Preserve the case of package names in versions2constraints and friends.

Fixes plone/plone.releaser#65

Files changed:
A news/65.bugfix
M plone/releaser/base.py
M plone/releaser/buildout.py
M plone/releaser/pip.py
M plone/releaser/tests/test_buildout.py
M plone/releaser/tests/test_pip.py
M plone/releaser/tests/test_versions2constraints.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2024-04-02T14:43:04+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@41fd5b2

Merge pull request #66 from plone/maurits-preserve-case

Preserve the case of package names in versions2constraints and friends.

Files changed:
A news/65.bugfix
M plone/releaser/base.py
M plone/releaser/buildout.py
M plone/releaser/pip.py
M plone/releaser/tests/test_buildout.py
M plone/releaser/tests/test_pip.py
M plone/releaser/tests/test_versions2constraints.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Apr 2, 2024
@mauritsvanrees
[fc] Repository: plone.releaser
ecaafe2 
Branch: refs/heads/master
Date: 2024-03-29T17:31:39+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@c8c29e5

Preserve the case of package names in versions2constraints and friends.

Fixes plone/plone.releaser#65

Files changed:
A news/65.bugfix
M plone/releaser/base.py
M plone/releaser/buildout.py
M plone/releaser/pip.py
M plone/releaser/tests/test_buildout.py
M plone/releaser/tests/test_pip.py
M plone/releaser/tests/test_versions2constraints.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2024-04-02T14:43:04+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.releaser@41fd5b2

Merge pull request #66 from plone/maurits-preserve-case

Preserve the case of package names in versions2constraints and friends.

Files changed:
A news/65.bugfix
M plone/releaser/base.py
M plone/releaser/buildout.py
M plone/releaser/pip.py
M plone/releaser/tests/test_buildout.py
M plone/releaser/tests/test_pip.py
M plone/releaser/tests/test_versions2constraints.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve the case of package names in versions2constraints and friends. plone/plone.releaser
1 participant
@mauritsvanrees