Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Python 3.12 and drop Python 2 Support #18

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Add Support for Python 3.12 and drop Python 2 Support #18

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8160357
Try to add support for Python 3.12
pbauer Jan 23, 2024
65d6c5d
add classifier and changenote
pbauer Jan 23, 2024
958bab3
drop six
pbauer Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ Changelog

Breaking changes:

- *add item here*
- Add support for Python 3.12. Drop support for Python 2
[pbauer]

New features:

Expand Down
8 changes: 5 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,18 @@
"Environment :: Web Environment",
"Framework :: Plone",
"Framework :: Zope2",
"Framework :: Zope :: 4",
"Framework :: Zope :: 5",
"License :: OSI Approved :: BSD License",
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 2",
"Programming Language :: Python :: 2.7",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would declare support for Python >= 3.8.
But this is a really minor detail.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge the PR, and then remove the 3.6 and 3.7 classifiers.

"Programming Language :: Python :: Implementation :: CPython",
],
keywords='zope plone reload',
Expand Down