Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeprecationWarnings. #184

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Fix DeprecationWarnings. #184

merged 6 commits into from
Jan 24, 2025

Conversation

mauritsvanrees
Copy link
Member

No description provided.

@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

6.0.9 is too old, giving various errors.  See https://github.com/plone/plone.rest/actions/runs/12875351288?pr=184

And 6.0.14 may be too new, because it officially drops support for Python 3.8.
Otherwise on 3.12 you get a too old Pillow and on 3.9-3.11 a too old docutils.
Python 3.8 is not supported since Plone 6.0.14.

And it is too hard to use 6.0.13 on 3.8 and 6.0.14 on 3.9+: we would need a different requirements file for 3.8, otherwise pip fails with:

```
No matching distribution found for setuptools==75.6.0
```
@mauritsvanrees
Copy link
Member Author

This tries to fix the github actions as well, which have been broken on Python 3.9+ for a while. See for example this run with 3.9.

Version and requirements information containing docutils:
While:
  Installing releaser.
  [versions] constraint on docutils: 0.18.1
  Base installation request: 'zest.releaser[recommended]', 'zestreleaser.towncrier', 'towncrier', 'readme', 'docutils'
  Requirement of readme-renderer: docutils>=0.21.2
  Requirement of pyroma; extra == "recommended": docutils
  Requirement of readme_renderer[md]>=40: docutils>=0.21.2
Error: The requirement ('docutils>=0.21.2') is not allowed by your [versions] constraint (0.18.1)

And on 3.12 Pillow cannot be built.

Chosen solution now:

  • Update from 6.0.9 to 6.0.14.
  • Stop testing Python 3.8 on Plone 6, as it is not supported on 6.0.14, and it is hard to test only 3.8 and 6.0.13.
  • Do still test 5.2 on 3.8, though this is by far the slowest combination.
  • Start testing 6.0 on 3.13
  • And start testing Plone 6.1.

@davisagli
Copy link
Member

@mauritsvanrees @gforcada I made some more ambitious updates:

  1. Drop support for Plone 5.2
  2. Bump the version to 5.x (I created a 4.x branch from current main)
  3. Remove bbb module and a patch that is no longer used.

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit 6f4b6cf into main Jan 24, 2025
20 checks passed
@davisagli davisagli deleted the maurits-warnings branch January 24, 2025 19:48
@mauritsvanrees
Copy link
Member Author

We'll party like there is no Plone 5.2. ;-)
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants