-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DeprecationWarnings. #184
Conversation
@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
6.0.9 is too old, giving various errors. See https://github.com/plone/plone.rest/actions/runs/12875351288?pr=184 And 6.0.14 may be too new, because it officially drops support for Python 3.8.
958ff6d
to
0b2786d
Compare
Otherwise on 3.12 you get a too old Pillow and on 3.9-3.11 a too old docutils.
Python 3.8 is not supported since Plone 6.0.14. And it is too hard to use 6.0.13 on 3.8 and 6.0.14 on 3.9+: we would need a different requirements file for 3.8, otherwise pip fails with: ``` No matching distribution found for setuptools==75.6.0 ```
c599328
to
62e7fea
Compare
This tries to fix the github actions as well, which have been broken on Python 3.9+ for a while. See for example this run with 3.9.
And on 3.12 Pillow cannot be built. Chosen solution now:
|
@mauritsvanrees @gforcada I made some more ambitious updates:
@jenkins-plone-org please run jobs |
We'll party like there is no Plone 5.2. ;-) |
No description provided.