Further normalise http-examples, and no port hardcoding #1226
Conversation
This comment has been minimized.
This comment has been minimized.
|
@jenkins-plone-org please run jobs |
|
@mauritsvanrees could you rebase your PR please? Why am I missing the port normalization code in this PR that I saw in the other one? The CI jobs are green, is this code already in master? |
This is no longer needed, since we update normalize the http-examples output in test_documentation.py. Also, without hardcoded port, it becomes possible to introduce tox and run it in parallel, if we want.
…expected name. Uglier, but closer to reality.
mauritsvanrees
force-pushed
the
maurits/http-examples-normalize
branch
from
b414be0 to
0b699ea
Compare
Done.
The port normalisation on master was done and merged in PR #1215. |
|
@jenkins-plone-org please run jobs |
|
@mauritsvanrees thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
This is for master what I already did on 7.x.x.