Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test to work with the new way plone.rest returns errors #1755

Closed
wants to merge 1 commit into from

Conversation

wesleybl
Copy link
Member

After:

plone/plone.rest#179

BadRequest errors are returned as an object and not as a string. This fix here takes this into account. But for now the tests are skipped, so that the merge can be done before the plone.rest change is in a Plone version.

@mister-roboto
Copy link

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 0025301
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/65d8a1aea23aec0008a2a5a3

@wesleybl
Copy link
Member Author

@jenkins-plone-org please run jobs

After:

plone/plone.rest#179

BadRequest errors are returned as an object and not as a string. This
fix here takes this into account. But for now the tests are skipped, so
that the merge can be done before the plone.rest change is in a Plone
version.
@wesleybl
Copy link
Member Author

It may be that plone/plone.rest#179 is not necessary.

@wesleybl wesleybl marked this pull request as draft February 26, 2024 16:15
@wesleybl
Copy link
Member Author

wesleybl commented Mar 4, 2024

plone/plone.rest#179 it was not necessary.

@wesleybl wesleybl closed this Mar 4, 2024
@wesleybl wesleybl deleted the error_message branch March 4, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants