Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly globally disable comments in the tests that need it. #1805

Merged

Conversation

mauritsvanrees
Copy link
Member

@mauritsvanrees mauritsvanrees commented Sep 2, 2024

In Plone 6.1, when you actively activate plone.app.discussion, we may globally enable comments by default. This is when plone/plone.app.discussion#244 gets merged.

We already had eight or so tests that explicitly globally enable comments. Now we explicitly globally disable them in two others. Then the tests work in Plone 6.0 and 6.1.

See two test failures here for the plone.app.discussion PR: https://jenkins.plone.org/job/pull-request-6.1-3.10/311/


📚 Documentation preview 📚: https://plonerestapi--1805.org.readthedocs.build/

In Plone 6.1, when you actively activate plone.app.discussion, we may globally enable comments by default.
This is when plone/plone.app.discussion#244 gets merged.

We already had eight or so tests that explicitly globally enable comments.
Now we explicitly globally disable them in two others.
Then the tests work in Plone 6.0 and 6.1.

See two test failures here for the plone.app.discussion PR:
https://jenkins.plone.org/job/pull-request-6.1-3.10/311/
@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Member Author

On Jenkins 6.1 I am testing these two together:

https://github.com/plone/plone.app.discussion/pull/244
https://github.com/plone/plone.restapi/pull/1805

On the Jenkins 6.0 job it is just the current one.

@mauritsvanrees
Copy link
Member Author

3 Jenkins jobs pass, one fails with an unrelated timeout.
I merge, so this can get in a release today or tomorrow.

@mauritsvanrees mauritsvanrees merged commit 7b1f0f4 into main Sep 4, 2024
24 of 25 checks passed
@mauritsvanrees mauritsvanrees deleted the maurits-tests-globally-enable-disable-comments branch September 4, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants