Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiles: original data not always found #64

Closed
mauritsvanrees opened this issue Jul 14, 2022 · 0 comments · Fixed by #65
Closed

Tiles: original data not always found #64

mauritsvanrees opened this issue Jul 14, 2022 · 0 comments · Fixed by #65
Assignees
@mauritsvanrees

Comments

@mauritsvanrees
Copy link
Member

For details, see a failing test I am trying to solve in plone.app.tiles.
It looks like plone.scale already has the correct data, but does not use it.
@mauritsvanrees mauritsvanrees self-assigned this Jul 14, 2022
mauritsvanrees added a commit that referenced this issue Jul 14, 2022
@mauritsvanrees
Fixed getting original data for a tile.
0f7168c 
Fixes #64
@mauritsvanrees mauritsvanrees mentioned this issue Jul 14, 2022
Merged
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Jul 19, 2022
@mauritsvanrees
[fc] Repository: plone.scale
885e56c 
Branch: refs/heads/master
Date: 2022-07-14T16:04:36+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.scale@0f7168c

Fixed getting original data for a tile.

Fixes plone/plone.scale#64

Files changed:
A news/64.bugfix
M plone/scale/storage.py
Repository: plone.scale

Branch: refs/heads/master
Date: 2022-07-18T12:05:59+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.scale@8cde451

Fixed tests.

These tests used 'True' as dummy result, but that needs to be something that resembles an image now.

Files changed:
M plone/scale/tests/test_storage.py
Repository: plone.scale

Branch: refs/heads/master
Date: 2022-07-19T16:14:42+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.scale@c4ceb41

pre_scale: rename variable 'field' to 'value'.

That is a more correct name.

Files changed:
M plone/scale/storage.py
Repository: plone.scale

Branch: refs/heads/master
Date: 2022-07-19T16:18:22+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.scale@56c5fc6

Merge pull request #65 from plone/maurits-get-original-value-issue-64

Fixed getting original data for a tile.

Files changed:
A news/64.bugfix
M plone/scale/storage.py
M plone/scale/tests/test_storage.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauritsvanrees mauritsvanrees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed getting original data for a tile. plone/plone.scale
1 participant
@mauritsvanrees